Change badge colors #970
Merged
Change badge colors #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > `StatusBadge` component now uses `cn` utility for badge color classes based on status, removing `variant` logic. > > - **Behavior**: > - `StatusBadge` component in `StatusBadge.tsx` now uses `cn` utility to apply class names for badge colors based on `status`. > - Removes `variant` logic and directly maps `status` to specific color classes. > - Handles `Status.Completed`, `Status.Terminated`, `Status.Created`, `Status.Failed`, `Status.Canceled`, `Status.TimedOut`, `Status.Running`, and `Status.Queued`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for a6476e679ad0d9e50d7ef188f94d2b49a4238bdb. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 87eb26d in 13 seconds
More details
- Looked at
51lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/components/StatusBadge.tsx:10
- Draft comment:
Consider usingStatus.TimedOutinstead of the string "timed_out" for consistency with theStatusenum usage. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_qdPQD2DWtwbgNFmu
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 87eb26d in 13 seconds
More details
- Looked at
51lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/components/StatusBadge.tsx:10
- Draft comment:
UseStatus.TimedOutinstead of the string literal "timed_out" for consistency and type safety.
const statusText = status === Status.TimedOut ? "timed out" : status;
- Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_UQyoGBh0gv5nhj2i
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
StatusBadgecomponent now usescnutility for badge color classes based on status, removingvariantlogic.StatusBadgecomponent inStatusBadge.tsxnow usescnutility for class names based onstatus.variantlogic, directly mappingstatusto color classes.Status.Completed,Status.Terminated,Status.Created,Status.Failed,Status.Canceled,Status.TimedOut,Status.Running, andStatus.Queued.This description was created by
for 87eb26d. It will automatically update as commits are pushed.